[webkit-reviews] review denied: [Bug 76654] WebGL must allocate smaller drawing buffer if allocation fails : [Attachment 124099] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied yongsheng
<yongsheng.zhu at intel.com>'s request for review:
Bug 76654: WebGL must allocate smaller drawing buffer if allocation fails
https://bugs.webkit.org/show_bug.cgi?id=76654

Attachment 124099: Patch
https://bugs.webkit.org/attachment.cgi?id=124099&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124099&action=review


Thanks for working on this during the Chinese new year, but it needs more work.


> Source/WebCore/ChangeLog:4
> +	   the allocation fails. 

Try to keep the synopsis on one line.

> Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp:52
> +static float s_resourceAdjustedRatio = 0.5;

Should be const, not static.

>> Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp:248
>> +	    while ((s_currentResourceUsePixels + pixelDelta) >
s_maximumResourceUsePixels) {
> 
> I don't think making sure less than s_maximumResourceUsePixels is enough.
> 
> You should try creating a buffer with adjustedSize, check if it succeeds, if
not, try with half the size.  Do this until you get a valid backbuffer.

I agree with Mo's assessment.