[webkit-reviews] review denied: [Bug 77006] [StorageTracker] Make one able to set the local storage (tracker) database dir's path : [Attachment 124172] Patch

[bugzilla-daemon at webkit.org]

Anton D'Auria <adauria at apple.com> has denied Gustavo Lima Chaves
<glima at profusion.mobi>'s request for review:
Bug 77006: [StorageTracker] Make one able to set the local storage (tracker)
database dir's path
https://bugs.webkit.org/show_bug.cgi?id=77006

Attachment 124172: Patch
https://bugs.webkit.org/attachment.cgi?id=124172&action=review

------- Additional Comments from Anton D'Auria <adauria at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124172&action=review


> Source/WebCore/storage/StorageTracker.cpp:101
> +    if (!m_database.isOpen())

you mean, if (m_database.isOpen())

> Source/WebCore/storage/StorageTracker.cpp:107
> +    MutexLocker lockOrigins(m_originSetGuard);
> +    m_originSet.clear();

m_originSetGuard needs to be unlocked because it's locked again in
importOriginIdentifiers()
this will work:
{
    MutexLocker lockOrigins(m_originSetGuard);
    m_originSet.clear();
}