[webkit-reviews] review granted: [Bug 77109] WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap : [Attachment 124131] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 26 09:49:29 PST 2012


Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 77109: WebPreferencesStore: use DEFINE_STATIC_LOCAL for overrides HashMap
https://bugs.webkit.org/show_bug.cgi?id=77109

Attachment 124131: Patch
https://bugs.webkit.org/attachment.cgi?id=124131&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124131&action=review


> Source/WebKit2/Shared/WebPreferencesStore.cpp:188
> +    HashMap<String, bool>::const_iterator it =
boolTestRunnerOverridesMap().find(key);

You could use BoolOverridesMap::const_iterator here for style points.


More information about the webkit-reviews mailing list