[webkit-reviews] review granted: [Bug 76708] [Qt][WK2] REGRESSION(r105517): It made 49 tests timeout : [Attachment 124122] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 76708: [Qt][WK2] REGRESSION(r105517): It made 49 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=76708

Attachment 124122: Patch
https://bugs.webkit.org/attachment.cgi?id=124122&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124122&action=review


rs=me

> Source/WebKit2/ChangeLog:9
> +	   to pass. WebkitTestRunner doesn't show it's wrapping QQuickView,
which

its* ?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:69
>      , m_navigatorQtObjectEnabled(false)
> +    , m_renderToOffscreenBuffer(false)
>  {

I guess we could use this for creating thumbnails etc in the future or for
pixel tests?

> Tools/ChangeLog:10
> +	   (WTR::PlatformWebView::PlatformWebView): Use software rendering of
layers since the wrapping QQuickView isn't shown.

wrapped* ?

shown on screen? isn't visible?