[webkit-reviews] review granted: [Bug 77099] SVG + <object> tests are flakey : [Attachment 124115] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 26 06:51:37 PST 2012


Andreas Kling <kling at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 77099: SVG + <object> tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=77099

Attachment 124115: Patch
https://bugs.webkit.org/attachment.cgi?id=124115&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124115&action=review


r=me

> Source/WebCore/page/FrameView.cpp:912
> +    // If the embedded SVG document appears the first time, the
ownerRenderer has releady finished

Typo, already.

> Source/WebCore/page/FrameView.cpp:913
> +    // layout without knowing about the existance of the embedded SVG
document, because RenderReplaced

Typo, existence.

> LayoutTests/ChangeLog:8
> +	   Introduce a testcase that fails reproducable w/o needed guard
malloc, if we ever regress <object> sizing again.

Typo, reproducibly.


More information about the webkit-reviews mailing list