[webkit-reviews] review requested: [Bug 77070] All DFG helpers that may call out to arbitrary JS code must know where they were called from due to inlining and call stack walking : [Attachment 124066] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 22:38:14 PST 2012


Filip Pizlo <fpizlo at apple.com> has asked  for review:
Bug 77070: All DFG helpers that may call out to arbitrary JS code must know
where they were called from due to inlining and call stack walking
https://bugs.webkit.org/show_bug.cgi?id=77070

Attachment 124066: the patch
https://bugs.webkit.org/attachment.cgi?id=124066&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
- hopefully fixed build issues, but not sure, because I don't see them on my
box.

- added loads of tests.

- found one additional, related, bug that the testing revealed: inlining code
was not correctly setting aside all 6 call frame slots because of an off-by-one
bug.


More information about the webkit-reviews mailing list