[webkit-reviews] review granted: [Bug 77058] test-webkitpy: executive_unittest fails if PYTHONPATH isn't set : [Attachment 124034] fix ChangeLog

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 77058: test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
https://bugs.webkit.org/show_bug.cgi?id=77058

Attachment 124034: fix ChangeLog
https://bugs.webkit.org/attachment.cgi?id=124034&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124034&action=review


I don't really like this, but I also don't think it matters that much.	Please
add a comment about why we're doing this.  Specifically to allow this unittest
to call itself.

> Tools/Scripts/test-webkitpy:45
> +    webkit_root =
os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))

Why is this needed?  __file__ should always be absolute, no?