[webkit-reviews] review granted: [Bug 77059] Parsing test_expecations.txt + Skipped lists takes too long : [Attachment 124035] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 77059: Parsing test_expecations.txt + Skipped lists takes too long
https://bugs.webkit.org/show_bug.cgi?id=77059

Attachment 124035: Patch
https://bugs.webkit.org/attachment.cgi?id=124035&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124035&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:855
> +	   for test in self._parser.parse_skipped_tests(tests_to_skip):

Nit: I would iterate directly over tests_to_skip here and change
parse_skipped_tests to something like expectation_for_skipped_test(index,
test). 

Looks fine otherwise. I'm a bit surprised it's this slow, but there is so much
python-level path handling in the code that I'm not that surprised. You should
see how slow the MockFileSystem makes the unit tests :).