[webkit-reviews] review granted: [Bug 77033] Implement overridePreference for boolean preferences in WebKitTestRunner : [Attachment 124020] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 77033: Implement overridePreference for boolean preferences in
WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=77033

Attachment 124020: Patch
https://bugs.webkit.org/attachment.cgi?id=124020&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> I made a small change to the initial patch: instead of overwriting the
preferences, the getter now asks the override first.

Thanks! I'd appreciate a detailed explanation for posterity - I think that I
understand what you're saying, but only barely, and it will be more difficult
in a few months. I.e., what function gets called between tests, what
preferences it resets, and how that filters down to each page.