[webkit-reviews] review denied: [Bug 76996] [chromium] Fix ClipboardChromium::validateFilename to actually operate on extensions : [Attachment 123995] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 76996: [chromium] Fix ClipboardChromium::validateFilename to actually
operate on extensions
https://bugs.webkit.org/show_bug.cgi?id=76996

Attachment 123995: Patch
https://bugs.webkit.org/attachment.cgi?id=123995&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123995&action=review


> Source/WebCore/platform/chromium/ClipboardChromiumLinux.cpp:36
> +void ClipboardChromium::validateFilename(String& name, String& extension)
>  {
>      notImplemented();

Aren't null and forward slash not allowed?

> Source/WebKit/chromium/WebKit.gypi:150
> +	       ['OS!="linux"', {
> +		   'webkit_unittest_files': [
> +		       'tests/ClipboardChromiumTest.cpp',

We should run this test on Linux too.