[webkit-reviews] review denied: [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin : [Attachment 123943] Removed canAccess() method, added versioning in stream object

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Adenilson Cavalcanti
Silva <savagobr at yahoo.com>'s request for review:
Bug 73215: [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=73215

Attachment 123943: Removed canAccess() method, added versioning in stream
object
https://bugs.webkit.org/attachment.cgi?id=123943&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123943&action=review


Getting there, maybe Simon should have a look more.

I think the changelogs could be a bit more elaborate... ie. explain what it
really adds, and maybe how it is implemented (ie why use a QUrl inside)

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:101
> +QDataStream& operator<<(QDataStream& out, const QtWebSecurityOrigin &origin)

> +{
> +    out.setVersion(QDataStream::Qt_4_0);
> +    out << (origin.url().toEncoded().data());
> +    return out;
> +}

hmm, is this correct simon?

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:58
> +
> +    enum OriginPolicyFlags {
> +	   ContentHasSameOriginAccess = 0x0,
> +	   LocalContentHasRemoteAccess = 0x1,
> +	   LocalContentHasSystemLocalAccess = 0x2
> +    };

This is dead code for now, remove.

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:61
> +private:
> +    bool isLocalScheme(const QString&);

Is it ok to not have this in a private class?