[webkit-reviews] review granted: [Bug 77033] Implement overridePreference for boolean preferences in WebKitTestRunner : [Attachment 123982] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 12:09:57 PST 2012


Alexey Proskuryakov <ap at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 77033: Implement overridePreference for boolean preferences in
WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=77033

Attachment 123982: Patch
https://bugs.webkit.org/attachment.cgi?id=123982&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123982&action=review


What resets the preferences back for the next test? Please make sure that this
is well understood before landing.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:67
>  WK_EXPORT void WKBundleOverrideXSSAuditorEnabledForTestRunner(WKBundleRef
bundle, WKBundlePageGroupRef pageGroup, bool enabled);

Can this be removed now?


More information about the webkit-reviews mailing list