[webkit-reviews] review granted: [Bug 77022] Remote web inspector reentrancy fixes : [Attachment 123965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 11:35:22 PST 2012


Joseph Pecoraro <joepeck at webkit.org> has granted Leo Franchi <leo at kdab.com>'s
request for review:
Bug 77022: Remote web inspector reentrancy fixes
https://bugs.webkit.org/show_bug.cgi?id=77022

Attachment 123965: Patch
https://bugs.webkit.org/attachment.cgi?id=123965&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123965&action=review


> Source/WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:364
>  #if ENABLE(INSPECTOR)

A separate issue, but maybe the whole file/class should be in this enable.
The InspectorServer would be pretty useless without ENABLE(INSPECTOR) =)

r=me, this patch looks good to me.


More information about the webkit-reviews mailing list