[webkit-reviews] review granted: [Bug 76697] border-image should be implemented like a shorthand. : [Attachment 123955] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 76697: border-image should be implemented like a shorthand.
https://bugs.webkit.org/show_bug.cgi?id=76697

Attachment 123955: Patch
https://bugs.webkit.org/attachment.cgi?id=123955&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123955&action=review


> Source/WebCore/page/animation/AnimationBase.cpp:1123
>	   CSSPropertyBorderSpacing,
> +	   CSSPropertyBorderImage,

Nit: alphabetize

> LayoutTests/fast/css/border-image-style-length.html:19
> +e = document.getElementById('test');
> +e.style.borderImage = "url(dummy://test.png) 10 / 13px 1.5em 1em 10px";
> +shouldBe("e.style.length", "5");

Nit: I would also add a test case for webkitBorderImage (make sure it doesn't
expand).