[webkit-reviews] review granted: [Bug 77001] border-image should not crash when the source is not specified. : [Attachment 123951] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 09:12:29 PST 2012


Andreas Kling <kling at webkit.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 77001: border-image should not crash when the source is not specified.
https://bugs.webkit.org/show_bug.cgi?id=77001

Attachment 123951: Patch
https://bugs.webkit.org/attachment.cgi?id=123951&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123951&action=review


Looks good, r=me.

> Source/WebCore/css/CSSStyleSelector.cpp:4320
> +	   } else if (current->isPrimitiveValue())
> +	       // Set the appropriate rules for stretch/round/repeat of the
slices.
> +	       mapNinePieceImageRepeat(current, image);

Please add { } here, since the comment makes it two lines.


More information about the webkit-reviews mailing list