[webkit-reviews] review denied: [Bug 76977] Check if inner node is null in order to avoid crash. : [Attachment 123877] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 08:20:40 PST 2012


Andreas Kling <kling at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 76977: Check if inner node is null in order to avoid crash.
https://bugs.webkit.org/show_bug.cgi?id=76977

Attachment 123877: Patch
https://bugs.webkit.org/attachment.cgi?id=123877&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123877&action=review


> Source/WebCore/ChangeLog:9
> +	   It is missing to check if inner node is null in touch event handler
of event handler. It may cause
> +	   crash when page is loading. Especially, inner node can be null on
slow wireless network.

Why can the inner node be null on slow wireless networks?

> Source/WebCore/ChangeLog:12
> +	   No new tests. Speculative fix for crash.

We're gonna need a test, or an explanation of why a test is not possible.


More information about the webkit-reviews mailing list