[webkit-reviews] review denied: [Bug 76912] Web Inspector: TabbedEditorContainer should save open tabs. : [Attachment 123739] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 76912: Web Inspector: TabbedEditorContainer should save open tabs.
https://bugs.webkit.org/show_bug.cgi?id=76912

Attachment 123739: Patch
https://bugs.webkit.org/attachment.cgi?id=123739&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123739&action=review


> Source/WebCore/inspector/front-end/ScriptsPanel.js:36
> +    this._lastViewedFileSetting =
WebInspector.settings.createSetting("lastViewedFile", "");

Please use the old setting name here for the smooth transition.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:269
> +	   var previouslyViewedFiles =
this._previouslyViewedFilesSetting.get();

Please cover this code with tests

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1201
> +    addFirstSourceFrame: function(title, sourceFrame, tooltip) { },

This editor container API seems too verbose.