[webkit-reviews] review denied: [Bug 73156] [Microdata] Implement HTMLPropertiesCollection collection.namedItem() : [Attachment 116969] Updated patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 73156: [Microdata] Implement HTMLPropertiesCollection
collection.namedItem()
https://bugs.webkit.org/show_bug.cgi?id=73156

Attachment 116969: Updated patch
https://bugs.webkit.org/attachment.cgi?id=116969&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116969&action=review


This patch confused me.  It looks like there's a bunch of extra code in here
that we don't need anymore.  Am I confused?

> Source/WebCore/html/HTMLPropertiesCollection.cpp:202
> +    // FIXME: HTML5 specifies that this should return PropertyNodeList.
> +    return !namedItems.isEmpty() ? StaticNodeList::adopt(namedItems) : 0;

So, the nodelist this returns isn't live?  It's just static?

> Source/WebCore/html/HTMLPropertiesCollection.h:54
> +    bool canGetItemsForName(const String& name) const;

I'm confused.  Who calls this function?

> Source/WebCore/html/HTMLPropertiesCollection.idl:44
> +	   NodeList namedItem(in DOMString name);

This isn't marked Custom anymore, but you still have the custom bindings code
in your patch.	Can we remove that code?