[webkit-reviews] review denied: [Bug 73039] Implement registration of WebIntents : [Attachment 123859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 24 17:56:01 PST 2012


Adam Barth <abarth at webkit.org> has denied Greg Billock <gbillock at google.com>'s
request for review:
Bug 73039: Implement registration of WebIntents
https://bugs.webkit.org/show_bug.cgi?id=73039

Attachment 123859: Patch
https://bugs.webkit.org/attachment.cgi?id=123859&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123859&action=review


So, the main question here is whether we should have an <intent> tag or whether
intents should us the <meta> tag.  It's probably a good idea to add a
discussion of that issue in the ChangeLog, including links to the spec and the
relevant discussion on standards mailing lists.

I'm sorry to mark your patch r- for a ChangeLog issue, but in this case I think
it's important to explain the "why" behind the patch in the ChangeLog.	(Aside
from the <intent> issue, the rest of this patch looks great.)

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1640
> +void FrameLoaderClientImpl::registerIntentService(
> +	   const String& action,
> +	   const String& type,
> +	   const KURL& href,
> +	   const String& title,
> +	   const String& disposition) {

This should all be on one line.


More information about the webkit-reviews mailing list