[webkit-reviews] review granted: [Bug 76962] garden-o-matic pixel zoomer should let you look at every pixel of the image : [Attachment 123841] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 24 16:49:40 PST 2012
Ojan Vafai <ojan at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 76962: garden-o-matic pixel zoomer should let you look at every pixel of
the image
https://bugs.webkit.org/show_bug.cgi?id=76962
Attachment 123841: Patch
https://bugs.webkit.org/attachment.cgi?id=123841&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123841&action=review
Extra points if you fix the pixel zoomer in results.html as well. :)
>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/pixelzoomer.js:107
> + image.style.left = -(pixelzoomer._percentX * kZoomedResultWidth) +
containerBounds.width/2 + 'px';
> + image.style.top = -(pixelzoomer._percentY * kZoomedResultHeight) +
containerBounds.height/2 + 'px';
Nit: Need spaces around the /. I'd also wrap the whole equation in parens to
make it clear which part is math and which part is string concat.
More information about the webkit-reviews
mailing list