[webkit-reviews] review granted: [Bug 76850] Clipping of render layer boundaries does not take page scale into account : [Attachment 123719] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sami Kyostila
<skyostil at google.com>'s request for review:
Bug 76850: Clipping of render layer boundaries does not take page scale into
account
https://bugs.webkit.org/show_bug.cgi?id=76850

Attachment 123719: Patch
https://bugs.webkit.org/attachment.cgi?id=123719&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123719&action=review


It would be nice if the bug listed some real-world sites known by be broken.

>
LayoutTests/compositing/overflow/overflow-scaled-descendant-overlapping.html:25

> +    <div style="position: absolute; left: 400px; z-index: 1; background:
#0f0">
> +	   <!-- Green should appear on top. -->
> +    </div>
> +
> +    <div style="position: absolute; left: 400px; overflow: hidden">
> +	   <div style="-webkit-transform: translateZ(0); background: #f00">
> +	       <!-- Red should be hidden. -->
> +	   </div>

Please use 'red' and 'green' for colors, rather than hex values.

Also, use of css classes like '#indicator" makes the test self-documenting. I
also don't like inline style in general.