[webkit-reviews] review denied: [Bug 76946] Make DataTransferItemList::length() const. : [Attachment 123810] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 76946: Make DataTransferItemList::length() const.
https://bugs.webkit.org/show_bug.cgi?id=76946

Attachment 123810: Patch
https://bugs.webkit.org/attachment.cgi?id=123810&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123810&action=review


> Source/WebCore/ChangeLog:8
> +
> +	   No new tests. (OOPS!)

Please include a sentence saying why length should be const.  No new tests
seems fine, but you'll have to remove the OOPS.

> Source/WebCore/platform/chromium/DataTransferItemListChromium.cpp:67
> +    // FIXME: This is a pretty evil.
> +    const Vector<RefPtr<DataTransferItem> >& items = m_items;
> +   
clipboardChromium()->mayUpdateItems(const_cast<Vector<RefPtr<DataTransferItem>
>&>(items));

I would make m_items mutable with a FIXME saying that it will be fixed in
https://bugs.webkit.org/show_bug.cgi?id=76598 .