[webkit-reviews] review granted: [Bug 76749] run-webkit-tests --lint-test-files should lint all the ports by default : [Attachment 123794] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 76749: run-webkit-tests --lint-test-files should lint all the ports by
default
https://bugs.webkit.org/show_bug.cgi?id=76749

Attachment 123794: Patch
https://bugs.webkit.org/attachment.cgi?id=123794&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123794&action=review


> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:50
> +	   # Only lint the platform the user asked for.

This comment is not helpful.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:68
> +		   None,  # tests
> +		   port_to_lint.test_expectations(),
> +		   port_to_lint.test_configuration(),
> +		   True,  # is_lint_mode

Can you use named arguments here instead of comments?

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:99
> +    if options.lint_test_files:
> +	   return lint(port, options)

You missed deleting the manager.lint() call below.