[webkit-reviews] review granted: [Bug 76928] Accelerated drawing should force compositing mode : [Attachment 123776] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 76928: Accelerated drawing should force compositing mode
https://bugs.webkit.org/show_bug.cgi?id=76928

Attachment 123776: Patch 
https://bugs.webkit.org/attachment.cgi?id=123776&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123776&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1856
> +    if (settings->acceleratedDrawingEnabled())
> +	  
settings->setForceCompositingMode(LayerTreeHost::supportsAcceleratedCompositing
());
> +    else
> +	  
settings->setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::f
orceCompositingModeKey()) && LayerTreeHost::supportsAcceleratedCompositing());

This should probably be #if PLATFORM(MAC), and I think it deserves a comment or
reference to a radar.