[webkit-reviews] review granted: [Bug 76921] [WK2] FindController should not assume that ports do not want to highlight text matches : [Attachment 123765] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 76921: [WK2] FindController should not assume that ports do not want to
highlight text matches
https://bugs.webkit.org/show_bug.cgi?id=76921

Attachment 123765: Patch
https://bugs.webkit.org/attachment.cgi?id=123765&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123765&action=review


> Source/WebKit2/WebProcess/WebPage/FindController.cpp:111
> +	   bool shouldShowHighlight = options & FindOptionsShowHighlight;

Why have this code here outside the if statement if this is used only when
shouldShowOverlay is true?