[webkit-reviews] review denied: [Bug 76041] fast/text/unicode-variation-selector.html doesn't pass on Lion : [Attachment 123502] Patch (patched font added)

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Kenichi Ishibashi <bashi at chromium.org>'s request for
review:
Bug 76041: fast/text/unicode-variation-selector.html doesn't pass on Lion
https://bugs.webkit.org/show_bug.cgi?id=76041

Attachment 123502: Patch (patched font added)
https://bugs.webkit.org/attachment.cgi?id=123502&action=review

------- Additional Comments from mitz at webkit.org
Thanks for the patch. All variation selectors are combining marks, so there is
no need to treat them specially. In particular,
advanceByCombiningCharacterSequence() already handles to BMP variation
selectors (U+180B, U+180C, U+180D, U+FE00…U+FE0F) correctly. It is just not set
up to handle non-BMP marks. You should change the loop in
advanceByCombiningCharacterSequence() so that it gets and iterates by full
Unicode character instead of UTF-16 code unit.