[webkit-reviews] review denied: [Bug 75836] webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr : [Attachment 121631] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 75836: webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should
test stdout and stderr
https://bugs.webkit.org/show_bug.cgi?id=75836

Attachment 121631: Patch
https://bugs.webkit.org/attachment.cgi?id=121631&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121631&action=review


r- to remove the absolute paths from the stderr (and stdout) output. 
Otherwise, this looks great!

>
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_war
ning-expected.txt:10
> +  'stderr' => 'mismatched comment found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css
> +mismatched comment found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css
> +mismatched comment found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css
> +mismatched brace found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css
> +mismatched brace found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css
> +mismatched brace found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css
> +mismatched brace found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css
> +mismatched brace found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css
> +',

This will fail on the bots because the paths won't match.  You need to sanitize
the stdout and stderr output to remove the absolute paths up to the WebKit
source directory.  In other words, this error:

mismatched comment found in
/usr/local/google/home/haraken/chrome-build/src/third_party/WebKit/Tools/Script
s/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css

Should look like this:

mismatched comment found in
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_war
ning.css

I think you can use a regex on the stderr and stdout output to remove the
WebKit source directory path (sourceDir() from the webkitdirs.pm module).