[webkit-reviews] review denied: [Bug 75387] Get GDB to display a proper backtrace through JITted functions : [Attachment 123762] Proposed patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Sanjoy Das
<thedigitalangel at gmail.com>'s request for review:
Bug 75387: Get GDB to display a proper backtrace through JITted functions
https://bugs.webkit.org/show_bug.cgi?id=75387

Attachment 123762: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=123762&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I like this a lot.  Two issues:

1) Fix the build on Qt and Windows.  Seems like Qt doesn't like your use of
void*, which should be easy to fix with some static_cast's:


../../../../Source/JavaScriptCore/jit/GDBInterface.cpp:79: error: pointer of
type 'void *' used in arithmetic

And Windows is just complaining because the code using gcc/clang specific
stuff; probably best to put some #if !OS(WINDOWS) or similar around the
relevant code.

2) Would it be possible for you to make the JSCPlugin code use something other
than a makefile? For example, that makefile would not work on Mac.  But perhaps
autotools would.

Marking r- because of the Qt and Windows build.  Otherwise I think it's
probably good to go.