[webkit-reviews] review denied: [Bug 76925] dropzone does not normalize type strings : [Attachment 123775] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 76925: dropzone does not normalize type strings
https://bugs.webkit.org/show_bug.cgi?id=76925

Attachment 123775: Patch
https://bugs.webkit.org/attachment.cgi?id=123775&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123775&action=review


> Source/WebCore/ChangeLog:11
> +	   Covered by existing tests.

I would say that you changed/added a test case in
fast/events/dropzone-002.html.

> LayoutTests/ChangeLog:10
> +	   * fast/events/dropzone-002.html: Update layout test to check case
normalization as well.
> +	   Also fixes the test to use text/uri-list, since no
URL->text/uri-list special casing is
> +	   defined for new drag and drop APIs.

Does no special casing of URL->text/uri-list defined mean that string:url
should fail?  It seems bad to lose test coverage for that case: we should test
both string:url and string:text/uri-list.