[webkit-reviews] review denied: [Bug 76863] ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom : [Attachment 123756] WIP v2. Added Qt and CMake flags

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 76863: ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
https://bugs.webkit.org/show_bug.cgi?id=76863

Attachment 123756: WIP v2. Added Qt and CMake flags
https://bugs.webkit.org/attachment.cgi?id=123756&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123756&action=review


Use this commit as an example: http://trac.webkit.org/changeset/101323

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:109
> +ENABLE_SHADOW_DOM = ENABLE_SHADOW_DOM;

This means "on" by default when building from XCode.

> Source/WebCore/Configurations/FeatureDefines.xcconfig:109
> +ENABLE_SHADOW_DOM = ENABLE_SHADOW_DOM;

Ditto.

> Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:109
> +ENABLE_SHADOW_DOM = ENABLE_SHADOW_DOM;

Ditto.

> Source/WebKit2/Configurations/FeatureDefines.xcconfig:109
> +ENABLE_SHADOW_DOM = ENABLE_SHADOW_DOM;

Ditto.

> Tools/Scripts/build-webkit:301
> +	 define => "ENABLE_SHADOW_DOM", default => 1, value =>
\$shadowDomSupport },

Again, this is "on" by default.