[webkit-reviews] review granted: [Bug 76745] check-webkit-style of the chromium test_expectations.txt file takes too long : [Attachment 123428] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 76745: check-webkit-style of the chromium test_expectations.txt file takes
too long
https://bugs.webkit.org/show_bug.cgi?id=76745

Attachment 123428: Patch
https://bugs.webkit.org/attachment.cgi?id=123428&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123428&action=review


>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:220

>> +	def test_error_on_different_platform(self):
> 
> Do we have a test that checks different configurations (e.g., DEBUG vs
RELEASE)?

I think it might be good to capture just a few more expectations here, just in
case the machinery in layout_tests/models is refactored away or something.