[webkit-reviews] review granted: [Bug 76711] Web Inspector: [InspectorIndexedDB] Pass Database, object stores and indexes meta information to frontend. : [Attachment 123577] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 76711: Web Inspector: [InspectorIndexedDB] Pass Database, object stores and
indexes meta information to frontend.
https://bugs.webkit.org/show_bug.cgi?id=76711

Attachment 123577: Patch
https://bugs.webkit.org/attachment.cgi?id=123577&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123577&action=review


> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:149
> +    static PassRefPtr<OpenDatabaseCallback>
create(PassRefPtr<ExecutableWithDatabase> executableWithDatabase)

Here and in other places please use raw pointer instead of PassRefPtr if you
are not passing ownership.

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:204
> +public:
> +    static PassRefPtr<DatabaseLoaderCallback>
create(PassRefPtr<InspectorIndexedDBAgent::FrontendProvider> frontendProvider,
int requestId)

Raw pointer should be used for frontendProvider parameter here since you don't
pass ownership.

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:232
> +		   if (!idbIndex)

We may want to report about such failures to the front-end.

> Source/WebCore/inspector/front-end/IndexedDBModel.js:390
> +	   if (!request.callback)

Should be "if (!request)" ?