[webkit-reviews] review granted: [Bug 76837] Web Inspector: incorrect highlight position when searching in console : [Attachment 123751] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 24 10:30:35 PST 2012
Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 76837: Web Inspector: incorrect highlight position when searching in
console
https://bugs.webkit.org/show_bug.cgi?id=76837
Attachment 123751: Patch
https://bugs.webkit.org/attachment.cgi?id=123751&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123751&action=review
> Source/WebCore/inspector/front-end/ConsoleMessage.js:417
> + return regexObject.test(this._messageElement.textContent) ||
(this._anchorElement && regexObject.test(this._anchorElement.textContent));
Please use cached this._message instead of this._messageElement.textContent
here.
More information about the webkit-reviews
mailing list