[webkit-reviews] review denied: [Bug 73097] Calling event.preventDefault() on mouse events messes up scroll state in presence of iframes : [Attachment 123757] patch with updated test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 73097: Calling event.preventDefault() on mouse events messes up scroll
state in presence of iframes
https://bugs.webkit.org/show_bug.cgi?id=73097

Attachment 123757: patch with updated test
https://bugs.webkit.org/attachment.cgi?id=123757&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123757&action=review


> LayoutTests/fast/events/scroll-div-with-prevent-default-in-subframe.html:24
> +	   var result = (scrollAfterSetup == scrollAfterMoveToMainFrame) &&
(scrollAfterSetup == scrollAfterReturnToSubframe) ? "PASS" : "FAIL";

Ryosuke suggested printing the numbers when the test fails and leaving them out
when the test passes.

Looks like you opted to always leave them out. Reason?

> LayoutTests/fast/events/scroll-div-with-prevent-default-in-subframe.html:25
> +	   document.getElementById("console").appen

Looks like this line of code isn’t all there.