[webkit-reviews] review granted: [Bug 67790] <style scoped>: Implement registering of <style scoped> with the scoping element : [Attachment 123704] patch, updated

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 67790: <style scoped>: Implement registering of <style scoped> with the
scoping element
https://bugs.webkit.org/show_bug.cgi?id=67790

Attachment 123704: patch, updated
https://bugs.webkit.org/attachment.cgi?id=123704&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123704&action=review


> Source/WebCore/dom/Element.h:310
> +#if ENABLE(STYLE_SCOPED)
> +    void registerScopedHTMLStyleChild();
> +    void unregisterScopedHTMLStyleChild();
> +    bool hasScopedHTMLStyleChild() const;
> +    size_t numberOfScopedHTMLStyleChildren() const;
> +#endif

This plumbing-through just looks unkempt. Please consider cleaning up in
follow-up patches.

> Source/WebCore/testing/Internals.cpp:167
> +std::size_t Internals::numberOfScopedHTMLStyleChildren(const Element*
element, ExceptionCode& ec) const

Please kill remaining std prefixes.