[webkit-reviews] review granted: [Bug 70107] Custom written CSS lexer : [Attachment 123705] patch update

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 70107: Custom written CSS lexer
https://bugs.webkit.org/show_bug.cgi?id=70107

Attachment 123705: patch update
https://bugs.webkit.org/attachment.cgi?id=123705&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=123705&action=review


Looks good to me. It would have been nice to see a performance test that shows
the improvement (CSS parser is currently big enough CPU user that it should be
very possible to construct a synthetic test that shows the progression).
Setting to r+ based on Oliver's comment.

> Source/WebCore/css/CSSParser.cpp:7953
> +	   if (hasEscape)
> +	       return;
> +
> +	   switch (length) {
> +	   case 12:
> +	       if (isCaselessEqual(name + 2, "ottom-left"))
> +		   m_token = BOTTOMLEFT_SYM;
> +	       return;
> +
> +	   case 13:

I would prefer less empty lines, here and other places.