[webkit-reviews] review denied: [Bug 71816] [Qt] run-qtwebkit-tests doesn't consider crashes as failures : [Attachment 122409] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 24 06:17:16 PST 2012


Csaba Osztrogonac <ossy at webkit.org> has denied János Badics
<dicska at gmail.com>'s request for review:
Bug 71816: [Qt] run-qtwebkit-tests doesn't consider crashes as failures
https://bugs.webkit.org/show_bug.cgi?id=71816

Attachment 122409: proposed patch
https://bugs.webkit.org/attachment.cgi?id=122409&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122409&action=review


r- now, see the comments. 

And please check your patch with git diff --color 
to ensure not use <TAB> characters for indentation.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:579
> +	logText = cmd.logs['stdio'].getText()

We don't need this local variable. Why don't you pass
"cmd.logs['stdio'].getText()" to re.fidall directly?

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:582
> +	foundItems = re.findall("TOTALS: (?P<passed>\d+) passed,
(?P<failed>\d+) failed, (?P<skipped>\d+) skipped", logText)
> +	   if foundItems:
> +	       self.incorrectTests = int(foundItems[0][1])

Why did you copy these lines from commandComplete function?
We don't need to duplicate them.


More information about the webkit-reviews mailing list