[webkit-reviews] review denied: [Bug 76832] [Qt] Build fix when using force_static_libs_as_shared : [Attachment 123560] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 24 03:06:10 PST 2012


Simon Hausmann <hausmann at webkit.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 76832: [Qt] Build fix when using force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=76832

Attachment 123560: Patch.
https://bugs.webkit.org/attachment.cgi?id=123560&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I think the dependency is correct, but I don't think that it should be guarded
with force_static_libs_as_shared. It is a _real_ dependency and it should IMHO
be expressed as such, i.e. without the force_static_libs_as_shared scope.


More information about the webkit-reviews mailing list