[webkit-reviews] review denied: [Bug 76895] Adding Chromium feature to turn on encoding detector from response : [Attachment 123699] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 76895: Adding Chromium feature to turn on encoding detector from response
https://bugs.webkit.org/show_bug.cgi?id=76895

Attachment 123699: Patch
https://bugs.webkit.org/attachment.cgi?id=123699&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123699&action=review


> Source/WebKit/chromium/public/platform/WebURLResponse.h:177
> +    WEBKIT_EXPORT bool needsEncodingDetection() const;

This feels like a layering violation.  Why does the network stack need to know
about this?  Maybe this should be a method on WebDataSource instead?  It is not

clear to me where you call setNeedsEncodingDetection, but it looks like you
only
care about it when loading documents.  (WebDataSource is the API wrapper for
DocumentLoader.)