[webkit-reviews] review denied: [Bug 76873] Avoid spurious rebuilds on vs2010 due to DerivedSources not existing : [Attachment 123647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 16:20:18 PST 2012


Adam Barth <abarth at webkit.org> has denied Scott Graham <scottmg at chromium.org>'s
request for review:
Bug 76873: Avoid spurious rebuilds on vs2010 due to DerivedSources not existing
https://bugs.webkit.org/show_bug.cgi?id=76873

Attachment 123647: Patch
https://bugs.webkit.org/attachment.cgi?id=123647&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123647&action=review


> Source/WebCore/WebCore.gyp/WebCore.gyp:-1828
> -	   '<@(webcore_privateheader_files)',

This isn't correct.  If there are specific files we need to remove that don't
exist, we should remove them in the gypi.  This line of code should stay here
as far as I understand things.


More information about the webkit-reviews mailing list