[webkit-reviews] review granted: [Bug 72949] [GTK] Add WebKitDownload to WebKit2 GTK+ API : [Attachment 123551] Updated patch according to review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 15:56:06 PST 2012


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 72949: [GTK] Add WebKitDownload to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72949

Attachment 123551: Updated patch according to review
https://bugs.webkit.org/attachment.cgi?id=123551&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123551&action=review


Nice!

> Source/WebKit2/UIProcess/API/gtk/WebKitDownload.cpp:215
> +	* after an error and ##WebKitDownload::finished signal is emitted after
this one.

You have two ## here instead of just one. I'm not sure if that's reponsible for
making the doc build fail or not. Might want to double-check it before you
land.


More information about the webkit-reviews mailing list