[webkit-reviews] review denied: [Bug 76864] Implement flex-pack:distribute : [Attachment 123626] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 76864: Implement flex-pack:distribute
https://bugs.webkit.org/show_bug.cgi?id=76864

Attachment 123626: Patch
https://bugs.webkit.org/attachment.cgi?id=123626&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123626&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

You'll need to fix this.  It would also be nice to provide a link to the spec.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:584
> +	   if (flexPack == PackDistribute)
> +	       return availableFreeSpace / (2 * numberOfChildren);

What happens if we have 0 children?  Can we add a test case for that?