[webkit-reviews] review denied: [Bug 76684] Respects generic font family names during webfonts are loading : [Attachment 123250] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 14:02:01 PST 2012


MORITA Hajime <morrita at google.com> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 76684: Respects generic font family names during webfonts are loading
https://bugs.webkit.org/show_bug.cgi?id=76684

Attachment 123250: Patch
https://bugs.webkit.org/attachment.cgi?id=123250&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123250&action=review


> Source/WebCore/css/CSSFontFaceSource.cpp:40
>  

These extra dependencies are really sad. Also, there is
fontDataForGenericFamily in CSSFontSelector.cpp. 
So my feeling is that  getGenericFallbackFontData should be a part of 
CSSFontSelector, not CSSFontFaceSource, something like
CSSFontSelector::getGetFallbackFontData() ?


More information about the webkit-reviews mailing list