[webkit-reviews] review denied: [Bug 75946] The query selector for HTMLContentElement should follow the shadow dom spec. : [Attachment 123524] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 75946: The query selector for HTMLContentElement should follow the shadow
dom spec.
https://bugs.webkit.org/show_bug.cgi?id=75946

Attachment 123524: Patch
https://bugs.webkit.org/attachment.cgi?id=123524&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123524&action=review


Basically looks OK. Regarding to m_isValidSelector, I feel it as symptom of
missing "optional" class like boost::optional. Could you consider to add it to
WTF when you have time? Of couse it's a different topic from this bug.

> Source/WebCore/html/shadow/ContentSelectorQuery.cpp:99
> +    default:

Don't use default clause if we have all enums in the case statements. 
Then compilers can catch possible missing case.