[webkit-reviews] review granted: [Bug 75732] [chromium] Add WebSolidColorLayer interface to draw non-textured color layers from Aura. : [Attachment 123561] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 11:39:19 PST 2012


James Robinson <jamesr at chromium.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 75732: [chromium] Add WebSolidColorLayer interface to draw non-textured
color layers from Aura.
https://bugs.webkit.org/show_bug.cgi?id=75732

Attachment 123561: Patch
https://bugs.webkit.org/attachment.cgi?id=123561&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123561&action=review


R=me

> Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:65
> +    for (int x = 0; x < width; x += m_tileSize)

add curly braces for this for loop as well since it's more than one line (in
WebKit, braces are determined by the # of lines, not the # of statements)


More information about the webkit-reviews mailing list