[webkit-reviews] review granted: [Bug 76803] [V8] Add Uint8ClampedArray support : [Attachment 123516] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 76803: [V8] Add Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=76803

Attachment 123516: Patch
https://bugs.webkit.org/attachment.cgi?id=123516&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123516&action=review


Thanks very much for filing and fixing this. Marking r+, but please see the
above comments (in particular about getting rid of the separate Chromium
baseline for array-unit-tests.html) and watch the EWS bots before committing.

> Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:16
> + * this software without specific prior written permission.

Wrong version of copyright notice; should be the two-clause license from
Source/WebKit/LICENSE (with copyright Google, as you have here).

>
LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt:-
1
> -CONSOLE MESSAGE: line 222: Uncaught ReferenceError: Uint8ClampedArray is not
defined

Can you just remove this expectation at this point? I don't think it should be
needed any more.