[webkit-reviews] review denied: [Bug 76783] [GTK] Refactor GTK's accessibilitity code to be more modular : [Attachment 123493] 13. New files for the implementation of the AtkText interface

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 76783: [GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Attachment 123493: 13. New files for the implementation of the AtkText
interface
https://bugs.webkit.org/attachment.cgi?id=123493&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123493&action=review


> Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp:51
> +#include "htmlediting.h"
> +
> +#include <libgail-util/gail-util.h>
> +#include <pango/pango.h>

There is no newline needed between the includes here.

> Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceText.cpp:139
> +	       gchar* text = convertUniCharToUTF8(renderText->characters(),
renderText->textLength(), box->start(), box->end());

Wow! I think you could remove convertUniCharToUTF8 completely and just do:

String text = String(renderText->characters(), renderText->textLength());
g_string_append(text.substring(box->start(), box->end() -
box->start()).utf8().data());

text is being leaked here anyway.

I know this is just code movement, but you might as well fix this one.