[webkit-reviews] review granted: [Bug 76783] [GTK] Refactor GTK's accessibilitity code to be more modular : [Attachment 123490] 10. New files for the implementation of the AtkHypertext interface

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 76783: [GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Attachment 123490: 10. New files for the implementation of the AtkHypertext
interface
https://bugs.webkit.org/attachment.cgi?id=123490&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123490&action=review


> Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceHypertext.h:28
> +AtkHyperlink* webkitAccessibleHypertextGetLink(AtkHypertext*, gint index);
> +gint webkitAccessibleHypertextGetNLinks(AtkHypertext*);
> +gint webkitAccessibleHypertextGetLinkIndex(AtkHypertext*, gint charIndex);

Are these methods used outside the file? If not they shouldn't be listed here
and instead of should be declared at the top of the file and statically. This
seems to be an issue with all of the patches. If you like, you can make this
change after all the patches have landed.