[webkit-reviews] review granted: [Bug 76783] [GTK] Refactor GTK's accessibilitity code to be more modular : [Attachment 123483] 6. New files for the implementation of the AtkComponent interface

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 76783: [GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Attachment 123483: 6. New files for the implementation of the AtkComponent
interface
https://bugs.webkit.org/attachment.cgi?id=123483&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123483&action=review


Looks good, but consider the rename below.

> Source/WebCore/accessibility/gtk/WebKitAccessibleUtil.h:34
> +void contentsToAtk(WebCore::AccessibilityObject*, AtkCoordType,
WebCore::IntRect, gint* x, gint* y, gint* width = 0, gint* height = 0);

If you need to put a comment explaining the method before the definition, it's
a good sign that you should just rename the method to explain it.

contentsRelativetoAtkCoordinateType?