[webkit-reviews] review granted: [Bug 76750] [windows] Convert usage of GetDC to HWndDC Part 2. : [Attachment 123402] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 76750: [windows] Convert usage of GetDC to HWndDC Part 2.
https://bugs.webkit.org/show_bug.cgi?id=76750

Attachment 123402: Patch
https://bugs.webkit.org/attachment.cgi?id=123402&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123402&action=review


> Source/WebKit/win/FullscreenVideoController.cpp:494
> -    HDC windowDC = GetDC(m_hudWindow);
> -    HDC bitmapDC = CreateCompatibleDC(windowDC);
> -    ::ReleaseDC(m_hudWindow, windowDC);
> -    HGDIOBJ oldBitmap = SelectObject(bitmapDC, m_bitmap.get());
> +    OwnPtr<HDC> bitmapDC = createCompatibleDCForWindow(m_hudWindow);

I don't think the separate function is needed. You can just do: OwnPtr<HDC>
bitmapDC = CreateCompatibleDC(HwndDC(m_hudWindow));